Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: components/autofill/core/common/autofill_regexes_unittest.cc

Issue 1453193002: autofill: switch autofill_regexes to RE2 library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/common/autofill_regexes.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/autofill_regexes_unittest.cc
diff --git a/components/autofill/core/common/autofill_regexes_unittest.cc b/components/autofill/core/common/autofill_regexes_unittest.cc
index 05895c7360f5cf8f189be0688a06153d06043738..08838b40731a2ed95d5c3b0bb3b6b1a378f79c94 100644
--- a/components/autofill/core/common/autofill_regexes_unittest.cc
+++ b/components/autofill/core/common/autofill_regexes_unittest.cc
@@ -4,13 +4,9 @@
#include "components/autofill/core/common/autofill_regexes.h"
-#include "base/strings/string16.h"
-#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/browser/autofill_regex_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
-using base::ASCIIToUTF16;
-
namespace autofill {
TEST(AutofillRegexesTest, AutofillRegexes) {
tfarina 2015/11/18 18:03:10 Are these test cases enough Ilya? I'm not sure abo
@@ -38,8 +34,7 @@ TEST(AutofillRegexesTest, AutofillRegexes) {
const TestCase& test_case = kPositiveCases[i];
SCOPED_TRACE(test_case.input);
SCOPED_TRACE(test_case.pattern);
- EXPECT_TRUE(MatchesPattern(ASCIIToUTF16(test_case.input),
- ASCIIToUTF16(test_case.pattern)));
+ EXPECT_TRUE(MatchesPattern(test_case.input, test_case.pattern));
}
const TestCase kNegativeCases[] = {
@@ -58,8 +53,7 @@ TEST(AutofillRegexesTest, AutofillRegexes) {
const TestCase& test_case = kNegativeCases[i];
SCOPED_TRACE(test_case.input);
SCOPED_TRACE(test_case.pattern);
- EXPECT_FALSE(MatchesPattern(ASCIIToUTF16(test_case.input),
- ASCIIToUTF16(test_case.pattern)));
+ EXPECT_FALSE(MatchesPattern(test_case.input, test_case.pattern));
}
}
« no previous file with comments | « components/autofill/core/common/autofill_regexes.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698