components/autofill/core/browser/credit_card.cc - Issue 1453193002: autofill: switch autofill_regexes to RE2 library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.cc

Issue 1453193002: autofill: switch autofill_regexes to RE2 library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reviews Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/credit_card.cc

diff --git a/components/autofill/core/browser/credit_card.cc b/components/autofill/core/browser/credit_card.cc

index 00593e7436d82be86d1bedbcdbbea0ab73e9fac8..51d697f44c8df80e9f4adfb6e3de2630c96caef5 100644

--- a/components/autofill/core/browser/credit_card.cc

+++ b/components/autofill/core/browser/credit_card.cc

@@ -444,7 +444,7 @@ const std::pair<base::string16, base::string16> CreditCard::LabelPieces()

void CreditCard::SetInfoForMonthInputType(const base::string16& value) {

// Check if |text| is "yyyy-mm" format first, and check normal month format.

- if (!MatchesPattern(value, base::UTF8ToUTF16("^[0-9]{4}-[0-9]{1,2}$")))

+ if (!MatchesPattern(value, "^[0-9]{4}-[0-9]{1,2}$"))

return;

std::vector<base::StringPiece16> year_month = base::SplitStringPiece(