components/autofill/core/browser/autofill_regex_constants.cc - Issue 1453193002: autofill: switch autofill_regexes to RE2 library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_regex_constants.cc

Issue 1453193002: autofill: switch autofill_regexes to RE2 library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 14 tests failing Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_regex_constants.cc

diff --git a/components/autofill/core/browser/autofill_regex_constants.cc b/components/autofill/core/browser/autofill_regex_constants.cc

index 4aed1a53c579b8817bdca54a10f75b9a3053601d..c03a375f4da3d897309e1e0b7483803efe622eaa 100644

--- a/components/autofill/core/browser/autofill_regex_constants.cc

+++ b/components/autofill/core/browser/autofill_regex_constants.cc

@@ -110,7 +110,7 @@ const char kCityRe[] =

"|分區" // zh-TW

"|^시[^도·・]|시[·・]?군[·・]?구"; // ko-KR

const char kStateRe[] =

- "(?<!united )state|county|region|province"

+ "state|county|region|province"

"|land" // de-DE

"|county|principality" // en-UK

"|都道府県" // ja-JP