autofill: switch autofill_regexes to RE2 library

components/autofill/core/common/autofill_regexes.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/autofill_regexes.h"
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string16.h"
-#include "third_party/icu/source/i18n/unicode/regex.h"
+#include "base/strings/utf_string_conversions.h"
+#include "third_party/re2/re2/re2.h"
 
 namespace {
 
 // A singleton class that serves as a cache of compiled regex patterns.
 class AutofillRegexes {
  public:
   static AutofillRegexes* GetInstance();
 
   // Returns the compiled regex matcher corresponding to |pattern|.
-  icu::RegexMatcher* GetMatcher(const base::string16& pattern);
+  re2::RE2* GetMatcher(const base::string16& pattern);

[Evan Stade, 2015/11/23 16:38:39]

can you make this return a const ref?

 
  private:
   AutofillRegexes();
   ~AutofillRegexes();
   friend struct base::DefaultSingletonTraits<AutofillRegexes>;
 
   // Maps patterns to their corresponding regex matchers.
-  base::ScopedPtrHashMap<base::string16, scoped_ptr<icu::RegexMatcher>>
-      matchers_;
+  base::ScopedPtrHashMap<base::string16, scoped_ptr<re2::RE2>> matchers_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillRegexes);
 };
 
 // static
 AutofillRegexes* AutofillRegexes::GetInstance() {
   return base::Singleton<AutofillRegexes>::get();
 }
 
 AutofillRegexes::AutofillRegexes() {
 }
 
 AutofillRegexes::~AutofillRegexes() {
 }
 
-icu::RegexMatcher* AutofillRegexes::GetMatcher(const base::string16& pattern) {
+re2::RE2* AutofillRegexes::GetMatcher(const base::string16& pattern) {

[Ilya Sherman, 2015/11/20 22:27:59]

Please either change this API to use std::string, or add a TODO to make this
change later.

   auto it = matchers_.find(pattern);
   if (it == matchers_.end()) {
-    const icu::UnicodeString icu_pattern(pattern.data(), pattern.length());
-
-    UErrorCode status = U_ZERO_ERROR;
-    scoped_ptr<icu::RegexMatcher> matcher(
-        new icu::RegexMatcher(icu_pattern, UREGEX_CASE_INSENSITIVE, status));
-    DCHECK(U_SUCCESS(status));
-
+    re2::RE2::Options options;
+    options.set_case_sensitive(false);
+    scoped_ptr<re2::RE2> matcher(
+        new re2::RE2(base::UTF16ToUTF8(pattern), options));
+    DCHECK(matcher->ok());
     auto result = matchers_.add(pattern, matcher.Pass());
     DCHECK(result.second);
     it = result.first;
   }
   return it->second;
 }
 
 }  // namespace
 
 namespace autofill {
 
 bool MatchesPattern(const base::string16& input,
                     const base::string16& pattern) {

[Ilya Sherman, 2015/11/20 22:27:59]

Please either change this API to use std::string for the |pattern| (but not the
|input|), or add a TODO to make this change later.

[tfarina, 2015/11/25 17:20:23]

Done. But if I'm not wrong from looking at the logs there are more tests failing
because of this change. IsStringASCII check fails. So I'm still not sure if this
is a good suggestion.

-  icu::RegexMatcher* matcher =
-      AutofillRegexes::GetInstance()->GetMatcher(pattern);
-  icu::UnicodeString icu_input(input.data(), input.length());
-  matcher->reset(icu_input);
-
-  UErrorCode status = U_ZERO_ERROR;
-  UBool match = matcher->find(0, status);
-  DCHECK(U_SUCCESS(status));
-  return match == TRUE;
+  // TODO(isherman): Run performance tests to determine whether caching regex
+  // matchers is still useful now that we've switched from ICU to RE2.
+  // http://crbug.com/470065
+  re2::RE2* matcher = AutofillRegexes::GetInstance()->GetMatcher(pattern);
+  return re2::RE2::PartialMatch(base::UTF16ToUTF8(input), *matcher);
 }
 
 }  // namespace autofill