Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1453133002: Eliminate Chromevox log spam. (Closed)

Created:
5 years, 1 month ago by Peter Lundblad
Modified:
5 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate Chromevox log spam. Don't try to show the focus ring on other platforms than Chrome OS. R=dtseng@chromium.org BUG=None Committed: https://crrev.com/f822598d8cab655cc77dc2dea470d82a0d8c1981 Cr-Commit-Position: refs/heads/master@{#360573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Peter Lundblad
5 years, 1 month ago (2015-11-17 13:43:50 UTC) #1
David Tseng
Please change the cl title (e.g. work around no active indicator support in ChromeVox Next); ...
5 years, 1 month ago (2015-11-17 18:00:19 UTC) #2
David Tseng
lgtm 
5 years, 1 month ago (2015-11-17 18:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453133002/1
5 years, 1 month ago (2015-11-19 13:17:10 UTC) #6
chromium-reviews
dtseng@chromium.org writes: > Please change the cl title (e.g. work around no active indicator support ...
5 years, 1 month ago (2015-11-19 13:20:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 13:37:56 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 13:39:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f822598d8cab655cc77dc2dea470d82a0d8c1981
Cr-Commit-Position: refs/heads/master@{#360573}

Powered by Google App Engine
This is Rietveld 408576698