content/browser/android/in_process/synchronous_compositor_output_surface.cc - Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_output_surface.cc

Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_output_surface.h ('k') | content/browser/compositor/browser_compositor_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/in_process/synchronous_compositor_output_surface.cc

diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc

index 2058fd18a1881eaed54e9f005cf554cf83211b25..3f7e5a2d4a950bf8efd9627b21c4d316297ab25b 100644

--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc

+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc

@@ -75,7 +75,7 @@ class SynchronousCompositorOutputSurface::SoftwareDevice

null_device_(SkBitmap::kARGB_8888_Config, 1, 1),

null_canvas_(&null_device_) {

}

- virtual void Resize(gfx::Size size) OVERRIDE {

+ virtual void Resize(const gfx::Size& size) OVERRIDE {

// Intentional no-op: canvas size is controlled by the embedder.

}

virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect) OVERRIDE {

@@ -156,7 +156,7 @@ bool SynchronousCompositorOutputSurface::BindToClient(

}

void SynchronousCompositorOutputSurface::Reshape(

- gfx::Size size, float scale_factor) {

+ const gfx::Size& size, float scale_factor) {

// Intentional no-op: surface size is controlled by the embedder.

}