cc/test/skia_common.cc - Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/skia_common.cc

Issue 145313006: [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to TOT and fixed build errors on other platforms Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/skia_common.cc

diff --git a/cc/test/skia_common.cc b/cc/test/skia_common.cc

index dfccd6479a0729cec595595e4fc084e043089e27..277a124e51c65c3f41c7e8b1eec6292414747cf3 100644

--- a/cc/test/skia_common.cc

+++ b/cc/test/skia_common.cc

@@ -25,7 +25,7 @@ void DrawPicture(unsigned char* buffer,

picture->Raster(&canvas, NULL, layer_rect, 1.0f);

}

-void CreateBitmap(gfx::Size size, const char* uri, SkBitmap* bitmap) {

+void CreateBitmap(const gfx::Size& size, const char* uri, SkBitmap* bitmap) {

SkImageInfo info = {

size.width(),

size.height(),