Fix temporary_android_dummy_target in build/all_android.gyp.

Fix temporary_android_dummy_target in build/all_android.gyp.

TBR=thakis@chromium.org
BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246883

[Bernhard Bauer, 2014-01-24 13:43:11]

Apologies for the double-commit; I thought fixing the syntax error would be
sufficient.

[commit-bot: I haz the power, 2014-01-24 13:43:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/145313005/30001

[commit-bot: I haz the power, 2014-01-24 13:43:33]

Change committed as 246883

[Nico, 2014-01-24 14:09:22]

Lgtm

Thanks & sorry :-/

since you saw this: How often do you source envsetup? (This wasn't
happening on bots, right?)
On Jan 24, 2014 5:43 AM, <commit-bot@chromium.org> wrote:

> Change committed as 246883
>
> https://codereview.chromium.org/145313005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bernhard Bauer, 2014-01-24 14:32:53]

On Fri, Jan 24, 2014 at 2:09 PM, Nico Weber <thakis@chromium.org> wrote:

> Lgtm
>
> Thanks & sorry :-/
>
> since you saw this: How often do you source envsetup? (This wasn't
> happening on bots, right?)
>
Yeah, it didn't happen on the bots.

I almost never source envsetup, because I keep a shell open for Android
building.

Is there some way we could automatize re-sourcing envsetup, similar to
using landmines for clobbering?


>  On Jan 24, 2014 5:43 AM, <commit-bot@chromium.org> wrote:
>
>> Change committed as 246883
>>
>> https://codereview.chromium.org/145313005/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-01-24 15:11:24]

On Fri, Jan 24, 2014 at 6:32 AM, Bernhard Bauer <bauerb@chromium.org> wrote:

> On Fri, Jan 24, 2014 at 2:09 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> Lgtm
>>
>> Thanks & sorry :-/
>>
>> since you saw this: How often do you source envsetup? (This wasn't
>> happening on bots, right?)
>>
> Yeah, it didn't happen on the bots.
>
> I almost never source envsetup, because I keep a shell open for Android
> building.
>
> Is there some way we could automatize re-sourcing envsetup, similar to
> using landmines for clobbering?
>

I'm trying to remove envsetup. Once it's gone, it doesn't really matter I
suppose.

What's "almost never"? Like, every 4 weeks?


>
>
>>  On Jan 24, 2014 5:43 AM, <commit-bot@chromium.org> wrote:
>>
>>> Change committed as 246883
>>>
>>> https://codereview.chromium.org/145313005/
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bernhard Bauer, 2014-01-24 15:43:58]

Once every computer restart, which varies, but every couple of weeks sounds
about right.

Bernhard.


On Fri, Jan 24, 2014 at 3:11 PM, Nico Weber <thakis@chromium.org> wrote:

> On Fri, Jan 24, 2014 at 6:32 AM, Bernhard Bauer <bauerb@chromium.org>wrote:
>
>> On Fri, Jan 24, 2014 at 2:09 PM, Nico Weber <thakis@chromium.org> wrote:
>>
>>> Lgtm
>>>
>>> Thanks & sorry :-/
>>>
>>> since you saw this: How often do you source envsetup? (This wasn't
>>> happening on bots, right?)
>>>
>> Yeah, it didn't happen on the bots.
>>
>> I almost never source envsetup, because I keep a shell open for Android
>> building.
>>
>> Is there some way we could automatize re-sourcing envsetup, similar to
>> using landmines for clobbering?
>>
>
> I'm trying to remove envsetup. Once it's gone, it doesn't really matter I
> suppose.
>
> What's "almost never"? Like, every 4 weeks?
>
>
>>
>>
>>>  On Jan 24, 2014 5:43 AM, <commit-bot@chromium.org> wrote:
>>>
>>>> Change committed as 246883
>>>>
>>>> https://codereview.chromium.org/145313005/
>>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.