Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: src/objects.cc

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mips64/builtins-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 9be16fb47bc869d54341ee49c2e2d71e573d1e67..55cb398c380f4afb8133b14bac95ee1855af1800 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1056,7 +1056,7 @@ MaybeHandle<Object> Object::GetPropertyWithDefinedGetter(
Debug* debug = isolate->debug();
// Handle stepping into a getter if step into is active.
// TODO(rossberg): should this apply to getters that are function proxies?
- if (debug->is_active()) debug->HandleStepIn(getter, false);
+ if (debug->is_active()) debug->HandleStepIn(getter);
return Execution::Call(isolate, getter, receiver, 0, NULL);
}
@@ -1071,7 +1071,7 @@ Maybe<bool> Object::SetPropertyWithDefinedSetter(Handle<Object> receiver,
Debug* debug = isolate->debug();
// Handle stepping into a setter if step into is active.
// TODO(rossberg): should this apply to getters that are function proxies?
- if (debug->is_active()) debug->HandleStepIn(setter, false);
+ if (debug->is_active()) debug->HandleStepIn(setter);
Handle<Object> argv[] = { value };
RETURN_ON_EXCEPTION_VALUE(isolate, Execution::Call(isolate, setter, receiver,
« no previous file with comments | « src/mips64/builtins-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698