Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/objects.cc

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/builtins-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <iomanip> 8 #include <iomanip>
9 #include <sstream> 9 #include <sstream>
10 10
(...skipping 1038 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 // behavior the same between hardware and simulators. 1049 // behavior the same between hardware and simulators.
1050 StackLimitCheck check(isolate); 1050 StackLimitCheck check(isolate);
1051 if (check.JsHasOverflowed()) { 1051 if (check.JsHasOverflowed()) {
1052 isolate->StackOverflow(); 1052 isolate->StackOverflow();
1053 return MaybeHandle<Object>(); 1053 return MaybeHandle<Object>();
1054 } 1054 }
1055 1055
1056 Debug* debug = isolate->debug(); 1056 Debug* debug = isolate->debug();
1057 // Handle stepping into a getter if step into is active. 1057 // Handle stepping into a getter if step into is active.
1058 // TODO(rossberg): should this apply to getters that are function proxies? 1058 // TODO(rossberg): should this apply to getters that are function proxies?
1059 if (debug->is_active()) debug->HandleStepIn(getter, false); 1059 if (debug->is_active()) debug->HandleStepIn(getter);
1060 1060
1061 return Execution::Call(isolate, getter, receiver, 0, NULL); 1061 return Execution::Call(isolate, getter, receiver, 0, NULL);
1062 } 1062 }
1063 1063
1064 1064
1065 Maybe<bool> Object::SetPropertyWithDefinedSetter(Handle<Object> receiver, 1065 Maybe<bool> Object::SetPropertyWithDefinedSetter(Handle<Object> receiver,
1066 Handle<JSReceiver> setter, 1066 Handle<JSReceiver> setter,
1067 Handle<Object> value, 1067 Handle<Object> value,
1068 ShouldThrow should_throw) { 1068 ShouldThrow should_throw) {
1069 Isolate* isolate = setter->GetIsolate(); 1069 Isolate* isolate = setter->GetIsolate();
1070 1070
1071 Debug* debug = isolate->debug(); 1071 Debug* debug = isolate->debug();
1072 // Handle stepping into a setter if step into is active. 1072 // Handle stepping into a setter if step into is active.
1073 // TODO(rossberg): should this apply to getters that are function proxies? 1073 // TODO(rossberg): should this apply to getters that are function proxies?
1074 if (debug->is_active()) debug->HandleStepIn(setter, false); 1074 if (debug->is_active()) debug->HandleStepIn(setter);
1075 1075
1076 Handle<Object> argv[] = { value }; 1076 Handle<Object> argv[] = { value };
1077 RETURN_ON_EXCEPTION_VALUE(isolate, Execution::Call(isolate, setter, receiver, 1077 RETURN_ON_EXCEPTION_VALUE(isolate, Execution::Call(isolate, setter, receiver,
1078 arraysize(argv), argv), 1078 arraysize(argv), argv),
1079 Nothing<bool>()); 1079 Nothing<bool>());
1080 return Just(true); 1080 return Just(true);
1081 } 1081 }
1082 1082
1083 1083
1084 // static 1084 // static
(...skipping 17108 matching lines...) Expand 10 before | Expand all | Expand 10 after
18193 if (cell->value() != *new_value) { 18193 if (cell->value() != *new_value) {
18194 cell->set_value(*new_value); 18194 cell->set_value(*new_value);
18195 Isolate* isolate = cell->GetIsolate(); 18195 Isolate* isolate = cell->GetIsolate();
18196 cell->dependent_code()->DeoptimizeDependentCodeGroup( 18196 cell->dependent_code()->DeoptimizeDependentCodeGroup(
18197 isolate, DependentCode::kPropertyCellChangedGroup); 18197 isolate, DependentCode::kPropertyCellChangedGroup);
18198 } 18198 }
18199 } 18199 }
18200 18200
18201 } // namespace internal 18201 } // namespace internal
18202 } // namespace v8 18202 } // namespace v8
OLDNEW
« no previous file with comments | « src/mips64/builtins-mips64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698