Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453103002: [turbofan] Remove dead code (related to the SeqStringChar lowering removal). (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead code (related to the SeqStringChar lowering removal). Committed: https://crrev.com/08eda0d7b0a4420d2ab3736058dc81150c5a3fdb Cr-Commit-Position: refs/heads/master@{#32034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M src/compiler/access-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Removing more code... Could you take a look, please?
5 years, 1 month ago (2015-11-17 11:34:32 UTC) #2
Benedikt Meurer
Less code is best code! :-) LGTM
5 years, 1 month ago (2015-11-17 11:35:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453103002/1
5 years, 1 month ago (2015-11-17 12:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 12:38:34 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 12:39:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08eda0d7b0a4420d2ab3736058dc81150c5a3fdb
Cr-Commit-Position: refs/heads/master@{#32034}

Powered by Google App Engine
This is Rietveld 408576698