Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1453073002: [bindings] Club attribute & accessor config for a runtime enabled feature in single |if| block (Closed)

Created:
5 years, 1 month ago by vivekg_samsung
Modified:
5 years, 1 month ago
Reviewers:
haraken, vivekg
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[bindings] Club attribute & accessor config for a runtime enabled feature in single |if| block This patch reduces the .text segment by ~14KB Before patch: * libwebcore_shared.so Text Data BSS Decimal 20546009 1161104 28132 21735245 * libmodules.so Text Data BSS Decimal 7000769 396240 5928 7402937 After patch: * libwebcore_shared.so Text Data BSS Decimal 20532025 1161104 28132 21721261 * libmodules.so Text Data BSS Decimal 7000681 396240 5928 7402849 BUG=469961 R=haraken@chromium.org Committed: https://crrev.com/04756fad7c8a67752432db3277fbe92c486566f5 Cr-Commit-Position: refs/heads/master@{#360053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -66 lines) Patch
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 chunk +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +32 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
vivekg
PTAL, thanks.
5 years, 1 month ago (2015-11-17 09:35:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453073002/1
5 years, 1 month ago (2015-11-17 09:35:53 UTC) #3
haraken
LGTM
5 years, 1 month ago (2015-11-17 09:39:00 UTC) #5
vivekg
On 2015/11/17 09:39:00, haraken wrote: > LGTM Thanks. This also removes the duplication done in ...
5 years, 1 month ago (2015-11-17 09:40:53 UTC) #6
haraken
On 2015/11/17 09:40:53, vivekg_ wrote: > On 2015/11/17 09:39:00, haraken wrote: > > LGTM > ...
5 years, 1 month ago (2015-11-17 09:42:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 11:01:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453073002/1
5 years, 1 month ago (2015-11-17 11:01:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 11:05:46 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 11:06:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04756fad7c8a67752432db3277fbe92c486566f5
Cr-Commit-Position: refs/heads/master@{#360053}

Powered by Google App Engine
This is Rietveld 408576698