Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453043003: Fix BytecodeArray::BodyDescriptor::SizeOf(). (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix BytecodeArray::BodyDescriptor::SizeOf(). Committed: https://crrev.com/67b99f7e77433b10d76cbd103afb04ed1510db24 Cr-Commit-Position: refs/heads/master@{#32027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/objects-body-descriptors-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453043003/1
5 years, 1 month ago (2015-11-17 08:28:09 UTC) #2
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-17 08:37:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 08:49:23 UTC) #6
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-17 09:24:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453043003/1
5 years, 1 month ago (2015-11-17 09:25:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 09:26:29 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 09:26:57 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67b99f7e77433b10d76cbd103afb04ed1510db24
Cr-Commit-Position: refs/heads/master@{#32027}

Powered by Google App Engine
This is Rietveld 408576698