Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 1453033002: X87: [turbofan] Move JSCallFunction specialization to JSCallReducer. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Move JSCallFunction specialization to JSCallReducer. port e5edd66d070952ad4243acf14aa7cc161be7fe18 (r32022) original commit message: This is the first part to refactoring the JSNativeContextSpecialization class, which has grown way too big recently. Also don't collect cross context feedback for the CallIC in general. Neither TurboFan nor Crankshaft can make any use of cross context JSFunction feedback that is collected by the CallIC, so there's no point in gathering that feedback at all (it just complicates the checking that is necessary in the compilers). What we should do instead at some point (when Crankshaft becomes less important) is to collect the SharedFunctionInfo as feedback for those cases. BUG= Committed: https://crrev.com/d9305784f96af1b244e4820d66d80560262a9263 Cr-Commit-Position: refs/heads/master@{#32024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-17 08:17:01 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-17 08:25:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453033002/1
5 years, 1 month ago (2015-11-17 08:25:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 08:43:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 08:43:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9305784f96af1b244e4820d66d80560262a9263
Cr-Commit-Position: refs/heads/master@{#32024}

Powered by Google App Engine
This is Rietveld 408576698