chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc - Issue 145303002: Convert Media Galleries to use base::File

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

Issue 145303002: Convert Media Galleries to use base::File (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa_data_provider.cc ('k') | chrome/browser/media_galleries/fileapi/picasa_file_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

diff --git a/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc b/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

index bced3c26d1770700aac802fdfbc0e4bc847037f5..061aa6db9ccd80a10b1aa8c68f409fbedbe29421 100644

--- a/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

+++ b/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

@@ -66,11 +66,11 @@ void VerifyTestAlbumTable(PicasaDataProvider* data_provider,

void VerifyTestAlbumsImagesIndex(PicasaDataProvider* data_provider,

base::FilePath test_folder_1_path,

base::FilePath test_folder_2_path) {

- base::PlatformFileError error;

+ base::File::Error error;

scoped_ptr<AlbumImages> album_1_images =

data_provider->FindAlbumImages("uid3", &error);

ASSERT_TRUE(album_1_images);

- EXPECT_EQ(base::PLATFORM_FILE_OK, error);

+ EXPECT_EQ(base::File::FILE_OK, error);

EXPECT_EQ(2u, album_1_images->size());

EXPECT_NE(album_1_images->end(), album_1_images->find("InBoth.jpg"));

EXPECT_EQ(test_folder_1_path.AppendASCII("InBoth.jpg"),

@@ -83,7 +83,7 @@ void VerifyTestAlbumsImagesIndex(PicasaDataProvider* data_provider,

scoped_ptr<AlbumImages> album_2_images =

data_provider->FindAlbumImages("uid5", &error);

ASSERT_TRUE(album_2_images);

- EXPECT_EQ(base::PLATFORM_FILE_OK, error);

+ EXPECT_EQ(base::File::FILE_OK, error);

EXPECT_EQ(2u, album_2_images->size());

EXPECT_NE(album_2_images->end(), album_2_images->find("InBoth.jpg"));

EXPECT_EQ(test_folder_1_path.AppendASCII("InBoth.jpg"),