Convert Media Galleries to use base::File

net/base/directory_lister_unittest.cc

Index: net/base/directory_lister_unittest.cc
diff --git a/net/base/directory_lister_unittest.cc b/net/base/directory_lister_unittest.cc
index 1df0226294f4b38ddcde517b91e28eb5ac571125..005ce0d51285e81b4caec6c62b5a3b5f5bda27c4 100644
--- a/net/base/directory_lister_unittest.cc
+++ b/net/base/directory_lister_unittest.cc
@@ -109,13 +109,9 @@ class DirectoryListerTest : public PlatformTest {
       for (int i = 0; i < kFilesPerDirectory; i++) {
         std::string file_name = base::StringPrintf("file_id_%d", i);
         base::FilePath file_path = dir_data.first.AppendASCII(file_name);
-        base::PlatformFile file = base::CreatePlatformFile(
-            file_path,
-            base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_WRITE,
-            NULL,
-            NULL);
-        ASSERT_NE(base::kInvalidPlatformFileValue, file);
-        ASSERT_TRUE(base::ClosePlatformFile(file));
+        base::File file(file_path,
+                        base::File::FLAG_CREATE | base::File::FLAG_WRITE);
+        ASSERT_TRUE(file.IsValid());

[wtc, 2014/01/24 20:41:56]

It seems that EXPECT_TRUE should suffice here.

Do we also need file.Close()?

[rvargas (doing something else), 2014/01/24 20:55:54]

Could be, but all other failures on Setup are considered fatal for this code.
Hard to test what all tests will do if the directory structure they expect is
not there, but I'd suspect they would not crash (which is to say that EXPECT
would be fine).

I can change the behavior on a separate CL if you want me to.
The file is closed by the destructor.

       }
       if (dir_data.second < kMaxDepth - 1) {
         for (int i = 0; i < kBranchingFactor; i++) {