Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1452993002: Subzero: Fix build warnings/errors under g++. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix build warnings/errors under g++. BUG= none TEST= make -j32 -f Makefile.standalone CXX=g++ LLVM_EXTRA_WARNINGS="-Wno-unknown-pragmas -Wno-unused-parameter -Wno-comment -Wno-enum-compare -Wno-strict-aliasing" STDLIB_FLAGS= (this command will compile but fail to link) R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a98091d437f3d2af2a7f4a9004d1f94356ae80f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/IceAssemblerARM32.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-17 03:59:50 UTC) #3
John
On 2015/11/17 03:59:50, stichnot wrote: Maybe add that check to the presubmit rule?
5 years, 1 month ago (2015-11-17 05:27:49 UTC) #5
John
lgtm
5 years, 1 month ago (2015-11-17 05:28:51 UTC) #6
Jim Stichnoth
On 2015/11/17 05:27:49, John wrote: > On 2015/11/17 03:59:50, stichnot wrote: > > Maybe add ...
5 years, 1 month ago (2015-11-17 05:39:51 UTC) #7
Jim Stichnoth
5 years, 1 month ago (2015-11-17 05:40:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a98091d437f3d2af2a7f4a9004d1f94356ae80f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698