Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: cc/output/overlay_processor.h

Issue 1452943002: cc: Fix overlay damage tracking bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/overlay_processor.h
diff --git a/cc/output/overlay_processor.h b/cc/output/overlay_processor.h
index 020c3c79a1695c177e4c3da7f1026f36470910c2..f348fb8e13ab0338009297a20eef06bb416083f8 100644
--- a/cc/output/overlay_processor.h
+++ b/cc/output/overlay_processor.h
@@ -29,8 +29,7 @@ class CC_EXPORT OverlayProcessor {
// overlays.
virtual bool Attempt(ResourceProvider* resource_provider,
RenderPassList* render_passes,
- OverlayCandidateList* candidates,
- gfx::Rect* damage_rect) = 0;
+ OverlayCandidateList* candidates) = 0;
};
using StrategyList = std::vector<scoped_ptr<Strategy>>;
@@ -39,21 +38,26 @@ class CC_EXPORT OverlayProcessor {
// Virtual to allow testing different strategies.
virtual void Initialize();
- bool ProcessForCALayers(ResourceProvider* resource_provider,
- RenderPassList* render_passes,
- CALayerOverlayList* ca_layer_overlays,
- OverlayCandidateList* overlay_candidates);
+ gfx::Rect GetAndResetOverlayDamage();
void ProcessForOverlays(ResourceProvider* resource_provider,
RenderPassList* render_passes,
- OverlayCandidateList* candidates,
+ OverlayCandidateList* overlay_candidates,
+ CALayerOverlayList* ca_layer_overlays,
gfx::Rect* damage_rect);
protected:
StrategyList strategies_;
OutputSurface* surface_;
+ gfx::Rect overlay_damage_rect_;
private:
+ bool ProcessForCALayers(ResourceProvider* resource_provider,
+ RenderPassList* render_passes,
+ OverlayCandidateList* overlay_candidates,
+ CALayerOverlayList* ca_layer_overlays,
+ gfx::Rect* damage_rect);
+
DISALLOW_COPY_AND_ASSIGN(OverlayProcessor);
};

Powered by Google App Engine
This is Rietveld 408576698