Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: ui/compositor/test/context_factories_for_test.cc

Issue 145293007: ui: No more TestCompositor. Use NullDraw contexts in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: testsnulldraw: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/compositor_switches.cc ('k') | ui/compositor/test/test_context_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/context_factories_for_test.cc
diff --git a/ui/compositor/test/context_factories_for_test.cc b/ui/compositor/test/context_factories_for_test.cc
index 63b2d3a2c74099d778ecb8f6cbe82835f717e125..045739d0a6551f8decb447b81569c2b6ea1a045d 100644
--- a/ui/compositor/test/context_factories_for_test.cc
+++ b/ui/compositor/test/context_factories_for_test.cc
@@ -9,7 +9,6 @@
#include "ui/compositor/compositor.h"
#include "ui/compositor/compositor_switches.h"
#include "ui/compositor/test/in_process_context_factory.h"
-#include "ui/compositor/test/test_context_factory.h"
#include "ui/gl/gl_implementation.h"
namespace {
@@ -28,35 +27,9 @@ void InitializeContextFactoryForTests(bool enable_pixel_output) {
CommandLine* command_line = CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kEnablePixelOutputInTests))
enable_pixel_output = true;
-
- bool use_test_contexts = true;
-
- if (gfx::HasInitializedNullDrawGLBindings())
- use_test_contexts = false;
-
- // Always use test contexts unless the disable command line flag is used.
- if (command_line->HasSwitch(switches::kDisableTestCompositor))
- use_test_contexts = false;
-
-#if defined(OS_CHROMEOS)
- // If the test is running on the chromeos envrionment (such as
- // device or vm bots), always use real contexts.
- if (base::SysInfo::IsRunningOnChromeOS())
- use_test_contexts = false;
-#endif
-
if (enable_pixel_output)
- use_test_contexts = false;
-
- if (use_test_contexts) {
- g_implicit_factory = new ui::TestContextFactory;
- } else {
- DCHECK_NE(gfx::kGLImplementationNone, gfx::GetGLImplementation());
- DVLOG(1) << "Using InProcessContextFactory";
- if (enable_pixel_output && gfx::HasInitializedNullDrawGLBindings())
- g_disable_null_draw = new gfx::DisableNullDrawGLBindings;
- g_implicit_factory = new ui::InProcessContextFactory();
- }
+ g_disable_null_draw = new gfx::DisableNullDrawGLBindings;
+ g_implicit_factory = new InProcessContextFactory();
ContextFactory::SetInstance(g_implicit_factory);
}
« no previous file with comments | « ui/compositor/compositor_switches.cc ('k') | ui/compositor/test/test_context_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698