build/android/gyp/java_cpp_enum.py - Issue 1452843002: Use hermetic timestamps in apkbuilder.py and refactor helper function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/java_cpp_enum.py

Issue 1452843002: Use hermetic timestamps in apkbuilder.py and refactor helper function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/java_cpp_enum.py

diff --git a/build/android/gyp/java_cpp_enum.py b/build/android/gyp/java_cpp_enum.py

index a82ebc2dfac3fab552e72b7c84f0bd2707dd086c..9299bce0eb4e3af55f94b43da3bac77d961b5722 100755

--- a/build/android/gyp/java_cpp_enum.py

+++ b/build/android/gyp/java_cpp_enum.py

@@ -345,7 +345,7 @@ def DoMain(argv):

with zipfile.ZipFile(options.srcjar, 'w', zipfile.ZIP_STORED) as srcjar:

for output_path, data in DoGenerate(input_paths):

- srcjar.writestr(build_utils.CreateHermeticZipInfo(output_path), data)

+ build_utils.AddToZipHermetic(srcjar, output_path, data=data)

else:

# TODO(agrieve): Delete this non-srcjar branch once GYP is gone.

output_paths = []

« no previous file with comments | « build/android/gyp/apkbuilder.py ('k') | build/android/gyp/java_google_api_keys.py » ('j') | no next file with comments »