Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/gyp/java_cpp_enum.py

Issue 1452843002: Use hermetic timestamps in apkbuilder.py and refactor helper function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/gyp/apkbuilder.py ('K') | « build/android/gyp/apkbuilder.py ('k') | build/android/gyp/java_google_api_keys.py » ('j') | build/android/gyp/util/build_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/java_cpp_enum.py
diff --git a/build/android/gyp/java_cpp_enum.py b/build/android/gyp/java_cpp_enum.py
index a0c9a8fa04b19824580906d49582c6ab8639030f..f1221a28b5e4e92b3839912848e9bccb2790baef 100755
--- a/build/android/gyp/java_cpp_enum.py
+++ b/build/android/gyp/java_cpp_enum.py
@@ -328,7 +328,7 @@ def DoMain(argv):
with zipfile.ZipFile(options.srcjar, 'w', zipfile.ZIP_STORED) as srcjar:
for output_path, data in DoGenerate(args):
- srcjar.writestr(build_utils.CreateHermeticZipInfo(output_path), data)
+ build_utils.AddToZipHermetic(srcjar, output_path, data=data)
else:
# TODO(agrieve): Delete this non-srcjar branch once GYP is gone.
if len(args) < 2:
« build/android/gyp/apkbuilder.py ('K') | « build/android/gyp/apkbuilder.py ('k') | build/android/gyp/java_google_api_keys.py » ('j') | build/android/gyp/util/build_utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698