content/browser/android/content_view_core_impl.cc - Issue 145283003: Switch AccessibilityMode to be a bitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 145283003: Switch AccessibilityMode to be a bitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src@enable

Patch Set: Switch IPC value to be the enum, rather than unsigned int Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 14a50be1120fb3303292312df419096a44305ded..33ffd2aae41baab5f4ec852cf7efded5f3584297 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -1779,11 +1779,11 @@ void ContentViewCoreImpl::SetAccessibilityEnabled(JNIEnv* env, jobject obj,

accessibility_state->OnScreenReaderDetected();

// If it was actually enabled globally, enable it for this RenderWidget now.

if (accessibility_state->IsAccessibleBrowser() && host_impl)

- host_impl->SetAccessibilityMode(AccessibilityModeComplete);

+ host_impl->AddAccessibilityMode(AccessibilityModeComplete);

} else {

- accessibility_state->DisableAccessibility();

+ accessibility_state->ResetAccessibilityMode();

if (host_impl)

- host_impl->SetAccessibilityMode(AccessibilityModeOff);

+ host_impl->ResetAccessibilityMode();

}