Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Unified Diff: content/renderer/render_view_impl.cc

Issue 145283003: Switch AccessibilityMode to be a bitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src@enable
Patch Set: Removed AccessibilityModeFlagRenderer, etc. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 6b49253b6493d0b7ad18221c21045dd07f50425a..7790ac286278b928b704f75a1eb298a097853d0b 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1075,7 +1075,7 @@ RenderViewImpl* RenderViewImpl::Create(
bool hidden,
int32 next_page_id,
const blink::WebScreenInfo& screen_info,
- AccessibilityMode accessibility_mode,
+ unsigned int accessibility_mode,
bool allow_partial_swap) {
DCHECK(routing_id != MSG_ROUTING_NONE);
RenderViewImplParams params(
@@ -5167,7 +5167,7 @@ void RenderViewImpl::OnSetBackground(const SkBitmap& background) {
SetBackground(background);
}
-void RenderViewImpl::OnSetAccessibilityMode(AccessibilityMode new_mode) {
+void RenderViewImpl::OnSetAccessibilityMode(unsigned int new_mode) {
if (accessibility_mode_ == new_mode)
return;
accessibility_mode_ = new_mode;
@@ -5175,10 +5175,13 @@ void RenderViewImpl::OnSetAccessibilityMode(AccessibilityMode new_mode) {
delete renderer_accessibility_;
renderer_accessibility_ = NULL;
}
- if (accessibility_mode_ == AccessibilityModeComplete)
+ if (accessibility_mode_ == AccessibilityModeOff)
+ return;
+
+ if (accessibility_mode_ & AccessibilityModeFlagPlatformFullTree)
aboxhall 2014/02/06 18:41:43 Open question: what do we do here if we need exten
renderer_accessibility_ = new RendererAccessibilityComplete(this);
#if !defined(OS_ANDROID)
- else if (accessibility_mode_ == AccessibilityModeEditableTextOnly)
+ else
renderer_accessibility_ = new RendererAccessibilityFocusOnly(this);
#endif
}
@@ -5945,7 +5948,10 @@ bool RenderViewImpl::didTapMultipleTargets(
const WebVector<WebRect>& target_rects) {
// Never show a disambiguation popup when accessibility is enabled,
// as this interferes with "touch exploration".
- if (accessibility_mode_ == AccessibilityModeComplete)
+ bool matchesAccessibilityModeComplete =
+ (accessibility_mode_ & AccessibilityModeComplete) ==
+ AccessibilityModeComplete;
+ if (matchesAccessibilityModeComplete)
return false;
gfx::Rect finger_rect(

Powered by Google App Engine
This is Rietveld 408576698