Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: blimp/net/packet_reader.h

Issue 1452823011: Make PacketReader/PacketWriter interfaces async-only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address wez feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/packet_reader.h
diff --git a/blimp/net/packet_reader.h b/blimp/net/packet_reader.h
index 407e2fdd2c1d7f3fc7343404a0e2bf41bf95a7e8..1d7dd6705472e3f236ddfa4fcd3c7e034893c86c 100644
--- a/blimp/net/packet_reader.h
+++ b/blimp/net/packet_reader.h
@@ -18,14 +18,12 @@ class BLIMP_NET_EXPORT PacketReader {
virtual ~PacketReader() {}
// Reads a packet from the connection.
- // Returns the size of the packet, in bytes, if the read operation executed
- // successfully.
- // Returns ERR_IO_PENDING if the operation will be executed asynchronously.
- // |cb| is later invoked with the packet size or an error code.
- // All other return values indicate errors and caller should stop using this
- // reader.
- virtual int ReadPacket(const scoped_refptr<net::GrowableIOBuffer>& buf,
- const net::CompletionCallback& cb) = 0;
+ // Passes net::OK to |cb| if the read operation executed successfully.
+ // Sets |buf.offset()| to the received message's size, and invokes |cb| with
+ // net::OK result on success.
+ // All other values indicate errors.
+ virtual void ReadPacket(const scoped_refptr<net::GrowableIOBuffer>& buf,
+ const net::CompletionCallback& cb) = 0;
};
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698