Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1452753002: Revert of Improve readability of power monitoring code and add additional (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve readability of power monitoring code and add additional (patchset #7 id:120001 of https://codereview.chromium.org/1432093002/ ) Reason for revert: Speculative revert since this may break page_cycler.typical_25 BUG=556653 Original issue's description: > Improve readability of power monitoring code and add additional > logging and validation. > > Committed: https://crrev.com/adce66abd74fb2d6e22da36eee85b7e324f962ba > Cr-Commit-Position: refs/heads/master@{#359640} TBR=mikecase@chromium.org,rnephew@google.com,rnephew@chromium.org,alexandermont@chromium.org Committed: https://crrev.com/717d915b88aca9da176adf6792379054f540e1a3 Cr-Commit-Position: refs/heads/master@{#359920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -286 lines) Patch
M tools/telemetry/telemetry/internal/platform/power_monitor/__init__.py View 3 chunks +0 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py View 2 chunks +38 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor_unittest.py View 2 chunks +8 lines, -50 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py View 2 chunks +20 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor_unittest.py View 2 chunks +0 lines, -27 lines 0 comments Download
D tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_temperature_monitor.py View 2 chunks +22 lines, -15 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py View 6 chunks +8 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/monsoon_power_monitor.py View 5 chunks +20 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py View 1 chunk +5 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/internal/platform/power_monitor/pm_mock.py View 1 chunk +0 lines, -61 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/power_monitor_controller.py View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/power_monitor_controller_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py View 3 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of Improve readability of power monitoring code and add additional
5 years, 1 month ago (2015-11-16 19:22:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452753002/1
5 years, 1 month ago (2015-11-16 19:23:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 21:21:26 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 21:22:25 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/717d915b88aca9da176adf6792379054f540e1a3
Cr-Commit-Position: refs/heads/master@{#359920}

Powered by Google App Engine
This is Rietveld 408576698