Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 145273028: Fix compilation of base for arm64 (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix compilation of base for arm64 Add support for the architecture to build/build_config.h (define new macro ARCH_CPU_ARM64 to identify the CPU architecture and set the other appropriate macros to 1). Fix DEBUG_BREAK_ASM() macro to expand to the correct instruction on arm64 cpu (as instruction set is not compatible with previous version of ARM instruction sets). BUG=339477 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/debug/debugger_posix.cc View 1 chunk +3 lines, -1 line 0 comments Download
M build/build_config.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sdefresne
PTAL
6 years, 10 months ago (2014-02-05 18:03:39 UTC) #1
Mark Mentovai
LGTM assuming __ARMEL__ isn’t defined when targeting ARMv8 (64).
6 years, 10 months ago (2014-02-05 18:46:30 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-05 21:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/145273028/1
6 years, 10 months ago (2014-02-05 21:49:48 UTC) #4
sdefresne
On 2014/02/05 18:46:30, Mark Mentovai wrote: > LGTM assuming __ARMEL__ isn’t defined when targeting ARMv8 ...
6 years, 10 months ago (2014-02-05 21:51:10 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 02:51:06 UTC) #6
Message was sent while issue was closed.
Change committed as 249246

Powered by Google App Engine
This is Rietveld 408576698