Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 145273015: Fix a leak in client_cert_resolver (Closed)

Created:
6 years, 11 months ago by tbarzic
Modified:
6 years, 10 months ago
CC:
chromium-reviews, glider+watch_chromium.org, stevenjb+watch_chromium.org, timurrrr+watch_chromium.org, oshima+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix a leak in client_cert_resolver BUG=272596 TEST=chromeos_unittests under valgrind Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247558

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M chromeos/network/client_cert_resolver.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/network/client_cert_util.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tbarzic
6 years, 10 months ago (2014-01-28 05:44:42 UTC) #1
pneubeck (no reviews)
Cool that you tracked that down! lgtm
6 years, 10 months ago (2014-01-28 08:13:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/145273015/1
6 years, 10 months ago (2014-01-28 18:39:35 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/memcheck/suppressions.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-28 18:39:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/145273015/100001
6 years, 10 months ago (2014-01-28 19:23:27 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 01:12:36 UTC) #6
Message was sent while issue was closed.
Change committed as 247558

Powered by Google App Engine
This is Rietveld 408576698