Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: mojo/public/platform/dart/mojo_natives.cc

Issue 1452703002: Dart: Remove error message from handle finalizer. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/platform/dart/mojo_natives.cc
diff --git a/mojo/public/platform/dart/mojo_natives.cc b/mojo/public/platform/dart/mojo_natives.cc
index 5d08fd3e9a346dd3ff6d2d5e5a9ab9def498d2bc..7b61d04b58118c7a9fb4ea9647529fbf124b3d3b 100644
--- a/mojo/public/platform/dart/mojo_natives.cc
+++ b/mojo/public/platform/dart/mojo_natives.cc
@@ -127,13 +127,7 @@ static void MojoHandleCloserCallback(void* isolate_data,
CloserCallbackPeer* callback_peer =
reinterpret_cast<CloserCallbackPeer*>(peer);
if (callback_peer->handle != MOJO_HANDLE_INVALID) {
- MojoResult res = MojoClose(callback_peer->handle);
- if (res == MOJO_RESULT_OK) {
- // If this finalizer callback successfully closes a handle, it means that
- // the handle has leaked from the Dart code, which is an error.
- MOJO_LOG(ERROR) << "Handle Finalizer closing handle:\n\tisolate: "
- << "\n\thandle: " << callback_peer->handle;
- }
+ MojoClose(callback_peer->handle);
}
delete callback_peer;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698