Issue 1452703002: Dart: Remove error message from handle finalizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1452703002: Dart: Remove error message from handle finalizer. (Closed)

Created:
5 years, 1 month ago by zra

Modified:
5 years, 1 month ago

Reviewers:
Cutch, abarth-chromium

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Remove error message from handle finalizer. There are use-cases in which the finalizer successfully closing a handle is not an error. BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/940e4aaf011fbc1f96962a08be8508a550475490

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	mojo/public/platform/dart/mojo_natives.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

5 years, 1 month ago (2015-11-17 17:38:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
940e4aaf011fbc1f96962a08be8508a550475490 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages