Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1452673002: Merge to XFA: Reland "Cleanup some numeric code."" (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Reland "Cleanup some numeric code."" This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1. This changes the various comparisons of char >= '0' && char <= '9' and char < '0' || char > '9' to use std::isdigit checks. It also cleans up a handful of hex to digit conversions to call one common method. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1449873003 . (cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650) Committed: https://pdfium.googlesource.com/pdfium/+/10cfea1fdafc8fcf1edd60bc783e9db9ef6229c0

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -365 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 5 chunks +22 lines, -19 lines 3 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 4 chunks +13 lines, -38 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 4 chunks +10 lines, -34 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 5 chunks +24 lines, -40 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 2 chunks +14 lines, -18 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 15 chunks +74 lines, -89 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 3 chunks +4 lines, -13 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 7 chunks +27 lines, -22 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 2 chunks +34 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 5 chunks +8 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 4 chunks +3 lines, -18 lines 2 comments Download
A core/src/fxcrt/fx_extension_unittest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 10 chunks +21 lines, -23 lines 1 comment Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
PTAL. Merge conflicts marked, nothing major mostly headers and ifdefs. https://codereview.chromium.org/1452673002/diff/1/core/include/fxcrt/fx_ext.h File core/include/fxcrt/fx_ext.h (left): https://codereview.chromium.org/1452673002/diff/1/core/include/fxcrt/fx_ext.h#oldcode67 ...
5 years, 1 month ago (2015-11-16 17:44:49 UTC) #1
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-16 18:05:26 UTC) #2
dsinclair
5 years, 1 month ago (2015-11-16 18:09:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
10cfea1fdafc8fcf1edd60bc783e9db9ef6229c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698