Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1452593002: Add support for building "ios_chrome_unittests" with gn. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
CC:
chromium-reviews, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ui_gfx
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for building "ios_chrome_unittests" with gn. Port all targets required to build "ios_chrome_unittests" from gyp to gn, adding reference to the GN target in the gyp files. The targets links but does not runs as resources bundles are still unsupported with gn. The resources are also not packed, but this will be done in a follow up CL in order to reduce the size of this already large CL. BUG=459705 Committed: https://crrev.com/0ddaed579debfcb0d6eacaab7eb8e8ea97577e20 Cr-Commit-Position: refs/heads/master@{#360552}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1253 lines, -17 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A ios/chrome/BUILD.gn View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/app/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/app/strings/BUILD.gn View 1 chunk +267 lines, -0 lines 0 comments Download
A ios/chrome/app/theme/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/BUILD.gn View 1 chunk +602 lines, -0 lines 2 comments Download
A ios/chrome/browser/variations/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A + ios/chrome/common/BUILD.gn View 1 chunk +9 lines, -12 lines 0 comments Download
A ios/chrome/common/app_group/BUILD.gn View 1 chunk +46 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 8 chunks +8 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_resources.gyp View 5 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A ios/chrome/test/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
M ios/ios_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/public/test/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
M ios/web/js_compile.gni View 4 chunks +82 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
sdefresne
dpranke: can you review //BUILD.gn (and the other .gn if you feel like doing extra ...
5 years, 1 month ago (2015-11-16 15:41:13 UTC) #2
Dirk Pranke
lgtm (I looked at all of the changes). https://codereview.chromium.org/1452593002/diff/1/ios/chrome/browser/BUILD.gn File ios/chrome/browser/BUILD.gn (right): https://codereview.chromium.org/1452593002/diff/1/ios/chrome/browser/BUILD.gn#newcode517 ios/chrome/browser/BUILD.gn:517: ":injected_js", ...
5 years, 1 month ago (2015-11-17 02:46:12 UTC) #3
blundell
rubberstamp-ish lgtm given that Dirk looked over the whole CL In any case once we're ...
5 years, 1 month ago (2015-11-17 09:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452593002/1
5 years, 1 month ago (2015-11-18 23:16:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-19 00:19:41 UTC) #8
sdefresne
droger: please review the following as OWNERS - ios/public/test/BUILD.gn - ios/ios_tests.gyp - ios/web/js_compile.gni
5 years, 1 month ago (2015-11-19 08:13:57 UTC) #10
droger
lgtm
5 years, 1 month ago (2015-11-19 08:56:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452593002/1
5 years, 1 month ago (2015-11-19 08:57:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:40:09 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:41:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ddaed579debfcb0d6eacaab7eb8e8ea97577e20
Cr-Commit-Position: refs/heads/master@{#360552}

Powered by Google App Engine
This is Rietveld 408576698