Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 1452563002: [turbofan] Add support for elements kind transitions. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for elements kind transitions. Extend the ElementAccessInfo machinery with support for elements kind transitions, which can be either in-place updates of the map (i.e. when going from FAST_SMI_ELEMENTS to FAST_ELEMENTS) or instance migrations utilizing the TransitionElementsKindStub. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/56791805769fc473d0418dd56effa2a01c31b188 Cr-Commit-Position: refs/heads/master@{#32003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -15 lines) Patch
M src/compiler/access-info.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/access-info.cc View 2 chunks +47 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +61 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-16 08:22:18 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the initial CL for the elements kind transitions. Please take a look. ...
5 years, 1 month ago (2015-11-16 08:24:56 UTC) #2
Jarin
lgtm. I know I repeat myself, but these methods are monsters. We should think about ...
5 years, 1 month ago (2015-11-16 08:59:07 UTC) #3
Jarin
lgtm. I know I repeat myself, but these methods are monsters. We should think about ...
5 years, 1 month ago (2015-11-16 08:59:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452563002/1
5 years, 1 month ago (2015-11-16 10:14:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 10:15:16 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 10:16:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56791805769fc473d0418dd56effa2a01c31b188
Cr-Commit-Position: refs/heads/master@{#32003}

Powered by Google App Engine
This is Rietveld 408576698