Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: Makefile.standalone

Issue 1452553002: Subzero: Add a "make check-presubmit" target. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove trailing comma Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pydir/szbuild_spec2k.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index f06ec157bda15388489b4a20587d0a383d4974c8..fc1c28d785bc9b6c841145f15e2e6f774e5c0361 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -417,16 +417,41 @@ ifeq ($(TARGET),arm32)
SETUP=SetupGccArmOpt
SPEC := -O2 --filetype=asm
endif
-
+SPECFLAGS :=
+SPECBUILDONLY := false
%.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
- ./pydir/szbuild_spec2k.py -v --force --target=$(TARGETFLAG) $(SPEC) $<
- ( cd ../../../tests/spec2k; \
+ ./pydir/szbuild_spec2k.py -v --force \
+ $(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $<
+ $(SPECBUILDONLY) || ( cd ../../../tests/spec2k; \
./run_all.sh RunTimedBenchmarks $(SETUP) train $< )
check-spec: $(ALLSPEC:=.spec2k)
check: check-lit check-unit check-xtest
+NPROCS := $(shell grep processor /proc/cpuinfo | wc -l)
+
+check-presubmit:
+ +make -f Makefile.standalone format
+ git diff --quiet
+ +make -f Makefile.standalone \
+ MINIMAL=1 check
+ +make -f Makefile.standalone \
+ DEBUG=1 CHECK_X86_ASM=1 check-unit
+ +make -f Makefile.standalone \
+ check check-spec
+ +make -f Makefile.standalone \
+ SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+ +make -f Makefile.standalone \
+ SPECFLAGS='--sz=--phi-edge-split=0' check-spec
+ +make -f Makefile.standalone \
+ TARGET=arm32 SPECBUILDONLY=true check-spec
+ +make -f Makefile.standalone \
+ TARGET=arm32 SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+ +make -f Makefile.standalone \
+ TARGET=arm32 ALLSPEC='176.gcc 181.mcf 254.gap' check-spec
+ echo Success
+
FORMAT_BLACKLIST =
# Add one of the following lines for each source file to ignore.
FORMAT_BLACKLIST += ! -name IceParseInstsTest.cpp
« no previous file with comments | « no previous file | pydir/szbuild_spec2k.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698