Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1452473002: Replace Glob implementation. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace Glob implementation. This makes MDL analysis another 5% faster. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/508b70bdabe4a2ca37435eea5686eebe8e77d2b4

Patch Set 1 #

Total comments: 4

Patch Set 2 : Tweaks for review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 5 chunks +14 lines, -14 lines 0 comments Download
A pkg/analyzer/lib/src/util/glob.dart View 1 1 chunk +90 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/util/glob_test.dart View 1 1 chunk +115 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/util/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 1 month ago (2015-11-15 03:47:15 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/1452473002/diff/1/pkg/analyzer/lib/src/util/glob.dart File pkg/analyzer/lib/src/util/glob.dart (right): https://codereview.chromium.org/1452473002/diff/1/pkg/analyzer/lib/src/util/glob.dart#newcode18 pkg/analyzer/lib/src/util/glob.dart:18: class Glob { Why not use the implementation from ...
5 years, 1 month ago (2015-11-15 16:27:47 UTC) #2
scheglov
PTAL https://codereview.chromium.org/1452473002/diff/1/pkg/analyzer/lib/src/util/glob.dart File pkg/analyzer/lib/src/util/glob.dart (right): https://codereview.chromium.org/1452473002/diff/1/pkg/analyzer/lib/src/util/glob.dart#newcode18 pkg/analyzer/lib/src/util/glob.dart:18: class Glob { On 2015/11/15 16:27:47, Brian Wilkerson ...
5 years, 1 month ago (2015-11-15 18:42:12 UTC) #3
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-15 19:25:10 UTC) #4
scheglov
5 years, 1 month ago (2015-11-15 20:17:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
508b70bdabe4a2ca37435eea5686eebe8e77d2b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698