Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145243005: Remove SkiaBenchmarking bitmap size limits. (Closed)

Created:
6 years, 10 months ago by f(malita)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove SkiaBenchmarking bitmap size limits. Some websites can easily blow through the current 4096 limit. Instead of imposing an arbitrary limit, let Skia attempt to allocate and handle potential failures. BUG=338865 R=nduca@chromium.org,pdr@chromium.org,piman@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M content/renderer/skia_benchmarking_extension.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
f(malita)
6 years, 10 months ago (2014-01-31 20:51:53 UTC) #1
piman
LGTM since it's behind a flag, but there could be security implications wrt int overflow ...
6 years, 10 months ago (2014-02-01 01:06:39 UTC) #2
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 10 months ago (2014-02-03 20:41:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/145243005/1
6 years, 10 months ago (2014-02-03 20:42:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 22:43:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255827
6 years, 10 months ago (2014-02-03 22:43:52 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:43:59 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:43:59 UTC) #8
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 10 months ago (2014-02-03 22:45:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/145243005/1
6 years, 10 months ago (2014-02-03 22:49:20 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:24:43 UTC) #11
commit-bot: I haz the power
Change committed as 248627
6 years, 10 months ago (2014-02-04 00:24:44 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:24:48 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:24:50 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:24:51 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:24:52 UTC) #16
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698