Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1452403003: don't try to adjust oom score with the suid sandbox if there is no such binary (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

don't try to adjust oom score with the suid sandbox if there is no such binary BUG=312380 Committed: https://crrev.com/d372b27a99e6827fd87a95bc802431ee83b81c08 Cr-Commit-Position: refs/heads/master@{#360262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452403003/1
5 years, 1 month ago (2015-11-18 01:21:09 UTC) #2
Mostyn Bramley-Moore
@rickyz: this small change avoids a useless error message in base/process/launch_posix.cc if there is no ...
5 years, 1 month ago (2015-11-18 01:21:58 UTC) #4
Mostyn Bramley-Moore
Oh BTW, the useless error message is: "LaunchProcess: failed to execvp:" (without any further information).
5 years, 1 month ago (2015-11-18 01:22:45 UTC) #5
rickyz (no longer on Chrome)
lgtm, thanks!
5 years, 1 month ago (2015-11-18 01:23:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452403003/1
5 years, 1 month ago (2015-11-18 01:25:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 02:11:04 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 02:11:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d372b27a99e6827fd87a95bc802431ee83b81c08
Cr-Commit-Position: refs/heads/master@{#360262}

Powered by Google App Engine
This is Rietveld 408576698