Issue 14524008: Make UsePosition::hint immutable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14524008: Make UsePosition::hint immutable. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make UsePosition::hint immutable. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14489

Patch Set 2 : Addressed comments by Sven Panne. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -19 lines)			Patch
	M	src/lithium-allocator.h	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
	M	src/lithium-allocator.cc	View		5 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/14524008/diff/1/src/lithium-allocator.h File src/lithium-allocator.h (right): https://codereview.chromium.org/14524008/diff/1/src/lithium-allocator.h#newcode264 src/lithium-allocator.h:264: LOperand* hint_; Change this to ...

7 years, 7 months ago (2013-04-30 07:07:45 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/14524008/diff/1/src/lithium-allocator.h File src/lithium-allocator.h (right): https://codereview.chromium.org/14524008/diff/1/src/lithium-allocator.h#newcode264 src/lithium-allocator.h:264: LOperand* hint_; On 2013/04/30 07:07:45, Sven ...

7 years, 7 months ago (2013-04-30 08:21:34 UTC) #3

Michael Starzinger

7 years, 7 months ago (2013-04-30 08:21:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14489 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14524008: Make UsePosition::hint immutable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Sven Panne. #

Messages