Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: styleguide/c++/c++11.html

Issue 1452373002: Add a table of contents to the c++11 style guide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: toc: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: styleguide/c++/c++11.html
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
index 42cdc7a456daf865a2356c20141a7c2e4cf7a074..a3a2fad160c641f4ae078b4fe35ab40cc9349797 100644
--- a/styleguide/c++/c++11.html
+++ b/styleguide/c++/c++11.html
@@ -35,12 +35,28 @@ href="https://groups.google.com/a/chromium.org/forum/#!forum/cxx">cxx@chromium.o
Ideally include a short blurb on what the feature is, and why you think it
should or should not be allowed. Ideally, the list will arrive at some
consensus and the wiki page will be updated to mention that consensus. If
-there's no consensus, <code>src/styleguide/C++/OWNERS</code> get to decide --
+there's no consensus, <code>src/styleguide/c++/OWNERS</code> get to decide --
for divisive features, we expect the decision to be to not use the feature yet
and possibly discuss it again a few months later, when we have more experience
with the language.</p>
-<h2 id="whitelist">C++11 Allowed Features</h2>
+<h2>Table of Contents</h2>
+<ol class="toc">
+<li>Allowed Features<ol>
+ <li><a href="#core-whitelist">Language</a></li>
+ <li><a href="#library-whitelist">Library</a></li>
+</ol></li>
Nico 2015/11/18 01:44:16 all your </li>s have an </ol> too for some reason
danakj 2015/11/18 20:48:44 I have a nested OL inside the LI. The opening is o
+<li>Banned Features<ol>
+ <li><a href="#core-blacklist">Language</a></li>
+ <li><a href="#library-blacklist">Library</a></li>
+</ol></li>
Nico 2015/11/18 01:44:16 …and this…
+<li>To Be Discussed<ol>
+ <li><a href="#core-review">Language</a></li>
+ <li><a href="#library-review">Library</a></li>
+</ol></li>
Nico 2015/11/18 01:44:16 …and this…
+</ol>
Nico 2015/11/18 01:44:16 …but this one should stay
+
+<h2 id="whitelist"><a name="core-whitelist"></a>C++11 Allowed Features</h2>
<p>The following features are currently allowed.</p>
@@ -258,7 +274,7 @@ Parameter pack</a></td>
</tbody>
</table>
-<h2 id="whitelist">C++11 Allowed Library Features</h2>
+<h2 id="whitelist"><a name="library-whitelist"></a>C++11 Allowed Library Features</h2>
<p>The following library features are currently allowed.</p>
@@ -305,7 +321,7 @@ Parameter pack</a></td>
<p>This section lists features that are not allowed to be used yet.
-<h3 id="blacklist_banned">C++11 Banned Features</h3>
+<h3 id="blacklist_banned"><a name="core-blacklist"></a>C++11 Banned Features</h3>
Nico 2015/11/18 01:44:16 (nit: since you have an ending tag now, you might
<p>This section lists C++11 features that are not allowed in the Chromium
codebase.
@@ -428,7 +444,7 @@ string literal</a></td>
</tbody>
</table>
-<h3 id="whitelist">C++11 Banned Library Features</h3>
+<h3 id="blacklist_stdlib"><a name="library-blacklist"></a>C++11 Banned Library Features</h3>
<p>This section lists C++11 library features that are not allowed in the Chromium codebase.</p>
@@ -472,7 +488,7 @@ string literal</a></td>
</table>
-<h3 id="blacklist_review">C++11 Features To Be Discussed</h3>
+<h3 id="blacklist_review"><a name="core-review"></a>C++11 Features To Be Discussed</h3>
<p>The following C++ language features are currently disallowed.
See the top of this page on how to propose moving a feature from this list
@@ -570,7 +586,7 @@ User-defined literals</a></td>
</tbody>
</table>
-<h3 id="blacklist_stdlib">C++11 Standard Library Features To Be Discussed</h3>
+<h3 id="blacklist_stdlib_review"><a name="library-review"></a>C++11 Standard Library Features To Be Discussed</h3>
<p>The following C++ library features are currently disallowed. See the top of this page on how to propose moving a feature from this list into the allowed or banned sections. Note that not all of these features work in all our compilers yet.</p>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698