Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1452363002: Modify summary Builder classes to avoid the use of Object. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify summary Builder classes to avoid the use of Object. Instead of passing around opaque Objects which are the result of calling the Builder.finish() methods, we pass around the Builder objects themselves, and we call finish() from within the generated code. This pushes the lack of type safety into the generated code, leaving the handwritten code type safe. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/178cebb634b0aff0ebae76a1f97247361c1ee92e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -196 lines) Patch
M pkg/analyzer/lib/src/summary/builder.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 34 chunks +132 lines, -130 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 21 chunks +50 lines, -45 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 3 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-17 22:37:28 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-17 23:44:27 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-17 23:50:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
178cebb634b0aff0ebae76a1f97247361c1ee92e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698