Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1452343002: Ignore break-word when white-space pre/nowrap is specified (Closed)

Created:
5 years, 1 month ago by eae
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore break-word when white-space pre/nowrap is specified Update our implementation to ignore break-word if white-space pre/nowrap is specified. This complies with latest version of the CSS Text spec [1] and matches the behavior of Firefox. R=leviw@chromium.org BUG=373502 TEST=fast/text/word-wrap-whitespace-pre.html fast/text/word-break.html 1: http://dev.w3.org/csswg/css-text-4/#white-space Committed: https://crrev.com/122865bf39b087bfc1c7f29eff8bb7c240d7a616 Cr-Commit-Position: refs/heads/master@{#360391}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -56 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/whitespace/pre-break-word.html View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/word-wrap-whitespace-pre.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/word-wrap-whitespace-pre-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/whitespace/pre-break-word-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-lion/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mountainlion/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-snowleopard/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/whitespace/pre-break-word-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/text/whitespace/pre-break-word-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-break-word-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-break-word-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
eae
5 years, 1 month ago (2015-11-17 22:05:56 UTC) #1
leviw_travelin_and_unemployed
lgtm
5 years, 1 month ago (2015-11-17 22:41:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452343002/1
5 years, 1 month ago (2015-11-17 22:43:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/136360)
5 years, 1 month ago (2015-11-17 23:25:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452343002/20001
5 years, 1 month ago (2015-11-17 23:31:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/142153)
5 years, 1 month ago (2015-11-18 02:07:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452343002/40001
5 years, 1 month ago (2015-11-18 18:23:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-18 19:45:07 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:46:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/122865bf39b087bfc1c7f29eff8bb7c240d7a616
Cr-Commit-Position: refs/heads/master@{#360391}

Powered by Google App Engine
This is Rietveld 408576698