Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1452323003: Remove the ability to trigger the edit bookmark dialog via URL. (Closed)

Created:
5 years, 1 month ago by Ted C
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the ability to trigger the edit bookmark dialog via URL. In the way way back dark ages, the edit bookmark dialog was triggered from the webui NTP by navigating to chrome://editbookmark with the bookmark type encoded in the URL. We have long long since moved to a native ntp and trigger it via a direct intent, so we can remove this logic and clean up the intent param handling to avoid invalid data. BUG=555925 Committed: https://crrev.com/ad512bd1b580da482a1e773f263f4c530989f740 Cr-Commit-Position: refs/heads/master@{#360264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -40 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivity.java View 4 chunks +14 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 1 month ago (2015-11-18 00:49:35 UTC) #2
newt (away)
lgtm
5 years, 1 month ago (2015-11-18 01:00:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452323003/1
5 years, 1 month ago (2015-11-18 01:13:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 02:14:42 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 02:15:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad512bd1b580da482a1e773f263f4c530989f740
Cr-Commit-Position: refs/heads/master@{#360264}

Powered by Google App Engine
This is Rietveld 408576698