Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 1452313004: Don't use cached subsequence when clip changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index 71cd3e2c0ad0d0cc35f8595ea3ea9e767f3473ef..87791f0202be5002e81e1e36a7b23b707ea661dc 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -221,8 +221,7 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon
m_paintLayer.stackingNode()->updateLayerListsIfNeeded();
Optional<SubsequenceRecorder> subsequenceRecorder;
- if (!paintingInfoArg.disableSubsequenceCache
- && !context->printing()
+ if (!context->printing()
&& !(paintingInfoArg.globalPaintFlags() & GlobalPaintFlattenCompositingLayers)
&& !(paintFlags & (PaintLayerPaintingReflection | PaintLayerPaintingRootBackgroundOnly | PaintLayerPaintingOverlayScrollbars))
&& m_paintLayer.stackingNode()->isStackingContext()
@@ -236,15 +235,6 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon
PaintLayerPaintingInfo paintingInfo = paintingInfoArg;
- // This is a workaround of ancestor clip change issue (crbug.com/533717).
- // TODO(wangxianzhu):
- // - spv1: This disables subsequence cache for all descendants of LayoutView with root-layer-scrolls because
- // LayoutView has overflow clip. Should find another workaround method working with root-layer-scrolls
- // if it ships before slimming paint v2. crbug.com/552030.
- // - spv2: Ensure subsequence cache works with ancestor clip change. crbug.com/536138.
- if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && m_paintLayer.layoutObject()->hasClipOrOverflowClip())
- paintingInfo.disableSubsequenceCache = true;
-
LayoutPoint offsetFromRoot;
m_paintLayer.convertToLayerCoords(paintingInfo.rootLayer, offsetFromRoot);

Powered by Google App Engine
This is Rietveld 408576698