Separate cert loading code from CertLibrary and move to src/chromeos

chrome/browser/chromeos/options/vpn_config_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/options/vpn_config_view.h"
 
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
@@ skipping 72 matching lines @@
   // Overridden from ui::ComboboxModel:
   virtual int GetItemCount() const OVERRIDE;
   virtual string16 GetItemAt(int index) OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ProviderTypeComboboxModel);
 };
 
 class VpnServerCACertComboboxModel : public ui::ComboboxModel {
  public:
-  explicit VpnServerCACertComboboxModel(CertLibrary* cert_library);
+  VpnServerCACertComboboxModel();
   virtual ~VpnServerCACertComboboxModel();
 
   // Overridden from ui::ComboboxModel:
   virtual int GetItemCount() const OVERRIDE;
   virtual string16 GetItemAt(int index) OVERRIDE;
 
  private:
-  CertLibrary* cert_library_;
-
   DISALLOW_COPY_AND_ASSIGN(VpnServerCACertComboboxModel);
 };
 
 class VpnUserCertComboboxModel : public ui::ComboboxModel {
  public:
-  explicit VpnUserCertComboboxModel(CertLibrary* cert_library);
+  VpnUserCertComboboxModel();
   virtual ~VpnUserCertComboboxModel();
 
   // Overridden from ui::ComboboxModel:
   virtual int GetItemCount() const OVERRIDE;
   virtual string16 GetItemAt(int index) OVERRIDE;
 
  private:
-  CertLibrary* cert_library_;
-
   DISALLOW_COPY_AND_ASSIGN(VpnUserCertComboboxModel);
 };
 
 // ProviderTypeComboboxModel ---------------------------------------------------
 
 ProviderTypeComboboxModel::ProviderTypeComboboxModel() {
 }
 
 ProviderTypeComboboxModel::~ProviderTypeComboboxModel() {
 }
 
 int ProviderTypeComboboxModel::GetItemCount() const {
   return PROVIDER_TYPE_MAX;
 }
 
 string16 ProviderTypeComboboxModel::GetItemAt(int index) {
   ProviderType type = static_cast<ProviderType>(index);
   return ProviderTypeToString(type);
 }
 
 // VpnServerCACertComboboxModel ------------------------------------------------
 
-VpnServerCACertComboboxModel::VpnServerCACertComboboxModel(
-    CertLibrary* cert_library)
-    : cert_library_(cert_library) {
+VpnServerCACertComboboxModel::VpnServerCACertComboboxModel() {
 }
 
 VpnServerCACertComboboxModel::~VpnServerCACertComboboxModel() {
 }
 
 int VpnServerCACertComboboxModel::GetItemCount() const {
-  if (cert_library_->CertificatesLoading())
+  if (CertLibrary::Get()->CertificatesLoading())
     return 1;  // "Loading"
   // "Default" + certs.
-  return cert_library_->GetCACertificates().Size() + 1;
+  return CertLibrary::Get()->NumCertificates(
+      CertLibrary::CERT_TYPE_SERVER_CA) + 1;
 }
 
 string16 VpnServerCACertComboboxModel::GetItemAt(int index) {
-  if (cert_library_->CertificatesLoading())
+  if (CertLibrary::Get()->CertificatesLoading())
     return l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_LOADING);
   if (index == 0)
     return l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_SERVER_CA_DEFAULT);
   int cert_index = index - 1;
-  return cert_library_->GetCACertificates().GetDisplayStringAt(cert_index);
+  return CertLibrary::Get()->GetCertDisplayStringAt(
+      CertLibrary::CERT_TYPE_SERVER_CA, cert_index);
 }
 
 // VpnUserCertComboboxModel ----------------------------------------------------
 
-VpnUserCertComboboxModel::VpnUserCertComboboxModel(
-    CertLibrary* cert_library)
-    : cert_library_(cert_library) {
+VpnUserCertComboboxModel::VpnUserCertComboboxModel() {
 }
 
 VpnUserCertComboboxModel::~VpnUserCertComboboxModel() {
 }
 
 int VpnUserCertComboboxModel::GetItemCount() const {
-  if (cert_library_->CertificatesLoading())
+  if (CertLibrary::Get()->CertificatesLoading())
     return 1;  // "Loading"
-  int num_certs = cert_library_->GetUserCertificates().Size();
+  int num_certs =
+      CertLibrary::Get()->NumCertificates(CertLibrary::CERT_TYPE_USER);
   if (num_certs == 0)
     return 1;  // "None installed"
   return num_certs;
 }
 
 string16 VpnUserCertComboboxModel::GetItemAt(int index) {
-  if (cert_library_->CertificatesLoading()) {
+  if (CertLibrary::Get()->CertificatesLoading()) {
     return l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_LOADING);
   }
-  if (cert_library_->GetUserCertificates().Size() == 0) {
+  if (CertLibrary::Get()->NumCertificates(CertLibrary::CERT_TYPE_USER) == 0) {
     return l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_USER_CERT_NONE_INSTALLED);
   }
-  return cert_library_->GetUserCertificates().GetDisplayStringAt(index);
+  return CertLibrary::Get()->GetCertDisplayStringAt(
+      CertLibrary::CERT_TYPE_USER, index);
 }
 
 }  // namespace internal
 
 VPNConfigView::VPNConfigView(NetworkConfigView* parent, VirtualNetwork* vpn)
-    : ChildNetworkConfigView(parent, vpn),
-      cert_library_(NULL) {
+    : ChildNetworkConfigView(parent, vpn) {
   Init(vpn);
 }
 
 VPNConfigView::VPNConfigView(NetworkConfigView* parent)
-    : ChildNetworkConfigView(parent),
-      cert_library_(NULL) {
+    : ChildNetworkConfigView(parent) {
   Init(NULL);
 }
 
 VPNConfigView::~VPNConfigView() {
-  if (cert_library_)
-    cert_library_->RemoveObserver(this);
+  CertLibrary::Get()->RemoveObserver(this);
 }
 
 views::View* VPNConfigView::GetInitiallyFocusedView() {
   // Put focus in the first editable field.
   if (server_textfield_)
     return server_textfield_;
   else if (service_textfield_)
     return service_textfield_;
   else if (provider_type_combobox_)
     return provider_type_combobox_;
@@ skipping 189 matching lines @@
 
 const std::string VPNConfigView::GetGroupName() const {
   return GetTextFromField(group_name_textfield_, false);
 }
 
 const std::string VPNConfigView::GetOTP() const {
   return GetTextFromField(otp_textfield_, true);
 }
 
 const std::string VPNConfigView::GetServerCACertNssNickname() const {
-  DCHECK(cert_library_);
   int index = server_ca_cert_combobox_ ?
       server_ca_cert_combobox_->selected_index() : 0;
   if (index == 0) {
     // First item is "Default".
     return std::string();
   } else {
-    DCHECK(cert_library_);
-    DCHECK_GT(cert_library_->GetCACertificates().Size(), 0);
+    DCHECK_GT(CertLibrary::Get()->NumCertificates(
+        CertLibrary::CERT_TYPE_SERVER_CA), 0);

[pneubeck (no reviews), 2013/05/03 09:42:54]

shouldn't this compare NumCertificates with cert_index ?

[stevenjb, 2013/05/03 17:02:32]

CertLibrary already does these checks; removed this one.

     int cert_index = index - 1;
-    return cert_library_->GetCACertificates().GetNicknameAt(cert_index);
+    return CertLibrary::Get()->GetCertNicknameAt(
+        CertLibrary::CERT_TYPE_SERVER_CA, cert_index);
   }
 }
 
 const std::string VPNConfigView::GetUserCertID() const {
-  DCHECK(cert_library_);
   if (!HaveUserCerts()) {
     return std::string();  // "None installed"
   } else {
     // Certificates are listed in the order they appear in the model.
     int index = user_cert_combobox_ ? user_cert_combobox_->selected_index() : 0;
-    return cert_library_->GetUserCertificates().GetPkcs11IdAt(index);
+    return CertLibrary::Get()->GetCertPkcs11IdAt(
+        CertLibrary::CERT_TYPE_USER, index);
   }
 }
 
 bool VPNConfigView::GetSaveCredentials() const {
   return save_credentials_checkbox_->checked();
 }
 
 void VPNConfigView::Init(VirtualNetwork* vpn) {
   if (vpn) {
     ProviderType type = vpn->provider_type();
@@ skipping 14 matching lines @@
                        onc::vpn::kUsername);
     ParseVPNUIProperty(&user_passphrase_ui_data_, vpn, credentials_dict_name,
                        onc::vpn::kPassword);
     ParseVPNUIProperty(&save_credentials_ui_data_, vpn, credentials_dict_name,
                        onc::vpn::kSaveCredentials);
   }
 
   views::GridLayout* layout = views::GridLayout::CreatePanel(this);
   SetLayoutManager(layout);
 
-  // VPN may require certificates, so always set the library and observe.
-  cert_library_ = CrosLibrary::Get()->GetCertLibrary();
-
   // Setup a callback if certificates are yet to be loaded.
-  if (!cert_library_->CertificatesLoaded())
-    cert_library_->AddObserver(this);
+  if (!CertLibrary::Get()->CertificatesLoaded())

[pneubeck (no reviews), 2013/05/03 09:42:54]

Why this restriction? The comment should explain why we don't always listen for
changes.

[stevenjb, 2013/05/03 17:02:32]

Changed to always add.

+    CertLibrary::Get()->AddObserver(this);
 
   const int column_view_set_id = 0;
   views::ColumnSet* column_set = layout->AddColumnSet(column_view_set_id);
   // Label.
   column_set->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0, 0);
   column_set->AddPaddingColumn(0, views::kRelatedControlSmallHorizontalSpacing);
   // Textfield, combobox.
   column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0,
@@ skipping 102 matching lines @@
 
   // Server CA certificate
   // Only provide Server CA when configuring a new VPN.
   if (!vpn) {
     layout->StartRow(0, column_view_set_id);
     server_ca_cert_label_ =
         new views::Label(l10n_util::GetStringUTF16(
             IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_SERVER_CA));
     layout->AddView(server_ca_cert_label_);
     server_ca_cert_combobox_model_.reset(
-        new internal::VpnServerCACertComboboxModel(cert_library_));
+        new internal::VpnServerCACertComboboxModel());
     server_ca_cert_combobox_ = new views::Combobox(
         server_ca_cert_combobox_model_.get());
     layout->AddView(server_ca_cert_combobox_);
     layout->AddView(new ControlledSettingIndicatorView(ca_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     server_ca_cert_label_ = NULL;
     server_ca_cert_combobox_ = NULL;
   }
 
   // User certificate label and input.
   if (enable_user_cert_) {
     layout->StartRow(0, column_view_set_id);
     user_cert_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USER_CERT));
     layout->AddView(user_cert_label_);
     user_cert_combobox_model_.reset(
-        new internal::VpnUserCertComboboxModel(cert_library_));
+        new internal::VpnUserCertComboboxModel());
     user_cert_combobox_ = new views::Combobox(user_cert_combobox_model_.get());
     user_cert_combobox_->set_listener(this);
     layout->AddView(user_cert_combobox_);
     layout->AddView(new ControlledSettingIndicatorView(user_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     user_cert_label_ = NULL;
     user_cert_combobox_ = NULL;
   }
 
@@ skipping 91 matching lines @@
 
   UpdateControls();
 
   // Set certificate combo boxes.
   VirtualNetwork* vpn = cros->FindVirtualNetworkByPath(service_path_);
   if (server_ca_cert_combobox_) {
     server_ca_cert_combobox_->ModelChanged();
     if (enable_server_ca_cert_ &&
         (vpn && !vpn->ca_cert_nss().empty())) {
       // Select the current server CA certificate in the combobox.
-      int cert_index = cert_library_->GetCACertificates().FindCertByNickname(
-          vpn->ca_cert_nss());
+      int cert_index = CertLibrary::Get()->GetCertIndexByNickname(
+          CertLibrary::CERT_TYPE_SERVER_CA, vpn->ca_cert_nss());
       if (cert_index >= 0) {
         // Skip item for "Default"
         server_ca_cert_combobox_->SetSelectedIndex(1 + cert_index);
       } else {
         server_ca_cert_combobox_->SetSelectedIndex(0);
       }
     } else {
       server_ca_cert_combobox_->SetSelectedIndex(0);
     }
   }
 
   if (user_cert_combobox_) {
     user_cert_combobox_->ModelChanged();
     if (enable_user_cert_ &&
         (vpn && !vpn->client_cert_id().empty())) {
-      int cert_index = cert_library_->GetUserCertificates().FindCertByPkcs11Id(
-          vpn->client_cert_id());
+      int cert_index = CertLibrary::Get()->GetCertIndexByPkcs11Id(
+          CertLibrary::CERT_TYPE_USER, vpn->client_cert_id());
       if (cert_index >= 0)
         user_cert_combobox_->SetSelectedIndex(cert_index);
       else
         user_cert_combobox_->SetSelectedIndex(0);
     } else {
       user_cert_combobox_->SetSelectedIndex(0);
     }
   }
 
   UpdateErrorLabel();
@@ skipping 58 matching lines @@
   if (group_name_textfield_)
     group_name_textfield_->SetEnabled(enable_group_name_ &&
                                       group_name_ui_data_.editable());
 }
 
 void VPNConfigView::UpdateErrorLabel() {
   NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
 
   // Error message.
   std::string error_msg;
-  if (UserCertRequired() && cert_library_->CertificatesLoaded()) {
+  if (UserCertRequired() && CertLibrary::Get()->CertificatesLoaded()) {
     if (!HaveUserCerts()) {
       error_msg = l10n_util::GetStringUTF8(
           IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PLEASE_INSTALL_USER_CERT);
     } else if (!IsUserCertValid()) {
       error_msg = l10n_util::GetStringUTF8(
           IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_REQUIRE_HARDWARE_BACKED);
     }
   }
   if (error_msg.empty() && !service_path_.empty()) {
     // TODO(kuan): differentiate between bad psk and user passphrases.
@@ skipping 17 matching lines @@
 
 void VPNConfigView::UpdateCanLogin() {
   parent_->GetDialogClientView()->UpdateDialogButtons();
 }
 
 bool VPNConfigView::UserCertRequired() const {
   return provider_type_ == PROVIDER_TYPE_L2TP_IPSEC_USER_CERT;
 }
 
 bool VPNConfigView::HaveUserCerts() const {
-  return cert_library_->GetUserCertificates().Size() > 0;
+  return CertLibrary::Get()->NumCertificates(CertLibrary::CERT_TYPE_USER) > 0;
 }
 
 bool VPNConfigView::IsUserCertValid() const {
   if (!user_cert_combobox_ || !enable_user_cert_)
     return false;
   int index = user_cert_combobox_->selected_index();
   if (index < 0)
     return false;
   // Currently only hardware-backed user certificates are valid.
-  if (cert_library_->IsHardwareBacked() &&
-      !cert_library_->GetUserCertificates().IsHardwareBackedAt(index))
+  if (CertLibrary::Get()->IsHardwareBacked() &&
+      !CertLibrary::Get()->IsCertHardwareBackedAt(
+          CertLibrary::CERT_TYPE_USER, index))
     return false;
   return true;
 }
 
 const std::string VPNConfigView::GetTextFromField(views::Textfield* textfield,
                                                   bool trim_whitespace) const {
   if (!textfield)
     return std::string();
   std::string untrimmed = UTF16ToUTF8(textfield->text());
   if (!trim_whitespace)
@@ skipping 21 matching lines @@
 
   property_ui_data->ParseOncProperty(
       network->ui_data(), onc,
       base::StringPrintf("%s.%s.%s",
                          onc::network_config::kVPN,
                          dict_key.c_str(),
                          key.c_str()));
 }
 
 }  // namespace chromeos