Handle decoding of vorbis files better on Android

webkit/media/android/audio_decoder_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/audio_decoder.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
 #include <sys/mman.h>
@@ skipping 100 matching lines @@
   base::SharedMemoryHandle encoded_data_handle;
   audio_decoder.ShareEncodedToProcess(&encoded_data_handle);
   base::FileDescriptor fd(audio_decoder.write_fd(), true);
 
   DVLOG(1) << "DecodeAudioFileData: Starting MediaCodec";
 
   // Start MediaCodec processing in the browser which will read from
   // encoded_data_handle for our shared memory and write the decoded
   // PCM samples (16-bit integer) to our pipe.
 
-  runner.Run(encoded_data_handle, fd);
+  runner.Run(encoded_data_handle, fd, data_size);
 
   // First, read the number of channels, the sample rate, and the
   // number of frames and a flag indicating if the file is an
   // ogg/vorbis file.  This must be coordinated with
   // WebAudioMediaCodecBridge!
   //
   // TODO(rtoy): If we know the number of samples, we can create the
   // destination bus directly and do the conversion directly to the
   // bus instead of buffering up everything before saving the data to
   // the bus.
 
   int input_fd = audio_decoder.read_fd();
-  unsigned long info[4];
+  unsigned long info[3];

[DaleCurtis, 2013/04/30 17:44:17]

Since you're reading / writing this structure across files, can you declare the
size somewhere both pieces of code can read it from?  Better yet, convert this
to a struct? :)

[Raymond Toy (Google), 2013/04/30 19:53:16]

Added the struct and a new header file to define it so it can be shared.

 
   DVLOG(1) << "Reading audio file info from fd " << input_fd;
   ssize_t nread = HANDLE_EINTR(read(input_fd, info, sizeof(info)));
   DVLOG(1) << "read:  " << nread << " bytes:\n"
            << " 0: number of channels = " << info[0] << "\n"
            << " 1: sample rate        = " << info[1] << "\n"
-           << " 2: number of frames   = " << info[2] << "\n"
-           << " 3: is vorbis          = " << info[3];
+           << " 2: number of frames   = " << info[2] << "\n";
 
   if (nread != sizeof(info))
     return false;
 
   unsigned number_of_channels = info[0];
   double file_sample_rate = static_cast<double>(info[1]);
 
   // Sanity checks
   if (!number_of_channels ||
       number_of_channels > media::limits::kMaxChannels ||
@@ skipping 35 matching lines @@
       destination_bus->channelData(k)[decoded_frames] =
           sample * (sample < 0 ? kMinScale : kMaxScale);
     }
     ++decoded_frames;
   }
 
   return true;
 }
 
 }  // namespace webkit_media