Handle decoding of vorbis files better on Android

media/base/android/webaudio_media_codec_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/webaudio_media_codec_bridge.h"
 
 #include <errno.h>
 #include <unistd.h>
 #include <vector>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "jni/WebAudioMediaCodecBridge_jni.h"
 
 
 using base::android::AttachCurrentThread;
 
 namespace media {
 
 void WebAudioMediaCodecBridge::RunWebAudioMediaCodec(
     base::SharedMemoryHandle encoded_audio_handle,
-    base::FileDescriptor pcm_output) {
-  WebAudioMediaCodecBridge bridge(encoded_audio_handle, pcm_output);
+    base::FileDescriptor pcm_output,
+    size_t data_size) {
+  WebAudioMediaCodecBridge bridge(encoded_audio_handle, pcm_output, data_size);
 
   bridge.DecodeInMemoryAudioFile();
 }
 
 WebAudioMediaCodecBridge::WebAudioMediaCodecBridge(
     base::SharedMemoryHandle encoded_audio_handle,
-    base::FileDescriptor pcm_output)
+    base::FileDescriptor pcm_output,
+    size_t data_size)
     : encoded_audio_handle_(encoded_audio_handle.fd),
-      pcm_output_(pcm_output.fd) {
+      pcm_output_(pcm_output.fd),
+      data_size_(data_size) {
   DVLOG(1) << "WebAudioMediaCodecBridge start **********************"
            << "input fd = " << encoded_audio_handle_
            << " output fd = " << pcm_output.fd;
 }
 
 WebAudioMediaCodecBridge::~WebAudioMediaCodecBridge() {
   if (close(pcm_output_)) {
     DVLOG(1) << "Couldn't close output fd " << pcm_output_
              << ": " << strerror(errno);
   }
 
   if (close(encoded_audio_handle_)) {
     DVLOG(1) << "Couldn't close shared mem fd " << encoded_audio_handle_
              << ": " << strerror(errno);
   }
 }
 
 bool WebAudioMediaCodecBridge::DecodeInMemoryAudioFile() {
   // Process the encoded data from |encoded_data_handle_|.
 
   JNIEnv* env = AttachCurrentThread();
   CHECK(env);
   jboolean decoded = Java_WebAudioMediaCodecBridge_decodeAudioFile(
       env,
       base::android::GetApplicationContext(),
       reinterpret_cast<intptr_t>(this),
-      encoded_audio_handle_);
+      encoded_audio_handle_,
+      data_size_);
 
   DVLOG(1) << "decoded = " << decoded;
   return decoded;
 }
 
 void WebAudioMediaCodecBridge::InitializeDestination(
     JNIEnv* env,
     jobject /*java object*/,
     jint channel_count,
     jint sample_rate,
-    jlong duration_microsec,
-    jboolean is_vorbis) {
+    jlong duration_microsec) {
   // Send information about this audio file: number of channels,
   // sample rate (Hz), number of frames, a flag indicating whether
   // this file is an audio/vorbis file.  Information is sent as a set of
   // 4 longs. This must be coordinated with DecodeAudioFileData!
 
-  unsigned long info[4] = {static_cast<unsigned long>(channel_count),
+  unsigned long info[3] = {static_cast<unsigned long>(channel_count),

[DaleCurtis, 2013/04/30 17:44:17]

Can you just drop the 3 and let it auto size?  All the static casts are
unnecessary, no?

[Raymond Toy (Google), 2013/04/30 17:57:49]

The static casts were added by benm@ to fix a WebView build to avoid
-Werror=narrowing.  This is probably only needed for the duration which is a
double being converted to a long.

                            static_cast<unsigned long>(sample_rate),
                            // The number of frames is the duration of the file
                            // (in microseconds) times the sample rate.
                            static_cast<unsigned long>(
                                0.5 + (duration_microsec * 0.000001 *
-                                      sample_rate)),
-                           is_vorbis ? 1ul : 0ul};
+                                      sample_rate))};
 
   DVLOG(1) << "InitializeDestination:"
            << "  channel count = " << channel_count
            << "  rate = " << sample_rate
-           << "  duration = " << duration_microsec << " microsec"
-           << "  vorbis = " << (is_vorbis ? "yes" : "no");
+           << "  duration = " << duration_microsec << " microsec";
 
   HANDLE_EINTR(write(pcm_output_, info, sizeof(info)));
 }
 
 void WebAudioMediaCodecBridge::OnChunkDecoded(
     JNIEnv* env,
     jobject /*java object*/,
     jobject buf,
     jint buf_size) {
 
@@ skipping 16 matching lines @@
     count -= bytes_written;
     buffer += bytes_written;
   }
 }
 
 bool WebAudioMediaCodecBridge::RegisterWebAudioMediaCodecBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 } // namespace