Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1452193003: [turbofan] Fix several OSR entries within class literals. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix several OSR entries within class literals. With do-expressions any expression used within literals can turn into an OSR entry-point. This means the literal object being constructed is then renamed to an OSR value and needs to be reloaded from the environment. R=rossberg@chromium.org TEST=mjsunit/regress/regress-osr-in-literal Committed: https://crrev.com/0c1c80b2af11d414076026a55c0dce6bc173f0b8 Cr-Commit-Position: refs/heads/master@{#32048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-osr-in-literal.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Andreas: PTAL. Caitlin: FYI.
5 years, 1 month ago (2015-11-17 14:28:12 UTC) #2
rossberg
lgtm
5 years, 1 month ago (2015-11-17 14:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452193003/1
5 years, 1 month ago (2015-11-17 14:49:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 14:51:11 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:51:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c1c80b2af11d414076026a55c0dce6bc173f0b8
Cr-Commit-Position: refs/heads/master@{#32048}

Powered by Google App Engine
This is Rietveld 408576698