Respect SkPictureRecorder::kPlaybackDrawPicture_RecordFlag for SkDrawables

Respect SkPictureRecorder::kPlaybackDrawPicture_RecordFlag for SkDrawables

Committed: https://skia.googlesource.com/skia/+/aa6f739c999fc2cdd64ba7a2332d333770722d06

[djsollen, 2015-11-17 13:59:44]

djsollen@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[mtklein, 2015-11-17 14:04:13]

lgtm

[djsollen, 2015-11-17 14:06:44]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2015-11-17 14:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1452193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1452193002/20001

[commit-bot: I haz the power, 2015-11-17 14:18:35]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aa6f739c999fc2cdd64ba7a2332d333770722d06

[reed1, 2015-11-17 14:45:11]

Why do we have this feature? For pictures, it seems a rather strict constract,
when we *should* be able to make that decision ourselves on a case-by-case
basis, unrolling pictures we choose to, and refing others.

For drawables, this is a big deal, since "unrolling" really changes a feature
(i.e. changes to the drawable will not be reflected in the recording). If we
really want this as a flag in recording, perhaps we shouldn't convolve these two
into the same bit.

Clearly callers can do this without our help (i.e. they can call
picture.draw(canvas) or drawable.draw(canvas)...

[mtklein, 2015-11-17 14:48:55]

> Clearly callers can do this without our help (i.e. they can call
picture.draw(canvas) or drawable.draw(canvas)...
Not for sub-pictures or sub-drawables.

[reed1, 2015-11-17 14:56:13]

Ah, true. If this is desireable (transitive pref) then we should consider that
as a option on the existing draw() methods.

[mtklein, 2015-11-17 14:56:40]

On 2015/11/17 at 14:56:13, reed wrote:
> Ah, true. If this is desireable (transitive pref) then we should consider that
as a option on the existing draw() methods.

That sgtm as an alternative to this flag.