Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1452123002: Move SkImage tests from SurfaceTest to ImageTest (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-00-skia_gpu=0-build
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkImage tests from SurfaceTest to ImageTest The general SkImage features seem to be tested in ImageTest instead of SurfaceTest. Helps in reviewing further reformatting of SurfaceTest. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/4e18413b78236391f507875ab5d60aa14cb3c1a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -425 lines) Patch
M tests/ImageTest.cpp View 1 chunk +430 lines, -0 lines 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +2 lines, -425 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-11-17 10:20:44 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-11-17 14:08:49 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1454653002 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-17 14:08:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452123002/1
5 years, 1 month ago (2015-11-18 06:41:25 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 06:53:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4e18413b78236391f507875ab5d60aa14cb3c1a5

Powered by Google App Engine
This is Rietveld 408576698