Issue 1452113002: [turbofan] Do not lower (One|Two)ByteSeqString(Get|Set)Char intrinsics.

Issue 1452113002: [turbofan] Do not lower (One|Two)ByteSeqString(Get|Set)Char intrinsics. (Closed)

Created:
5 years, 1 month ago by Jarin

Modified:
5 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Do not lower (One|Two)ByteSeqString(Get|Set)Char intrinsics. Committed: https://crrev.com/4832e99037958fec798982416330e5e7ace3bbbf Cr-Commit-Position: refs/heads/master@{#32028}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -46 lines)			Patch
	M	src/compiler/js-intrinsic-lowering.cc	View		2 chunks	+0 lines, -46 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jarin

Benedikt, since you asked for this you have the privilege to review.

5 years, 1 month ago (2015-11-17 09:30:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452113002/1

5 years, 1 month ago (2015-11-17 09:33:13 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/4832e99037958fec798982416330e5e7ace3bbbf Cr-Commit-Position: refs/heads/master@{#32028}

5 years, 1 month ago (2015-11-17 10:11:09 UTC) #7

Michael Starzinger

5 years, 1 month ago (2015-11-17 10:33:50 UTC) #8

Message was sent while issue was closed.

We could also kill AccessBuilder::ForSeqStringChar now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages