Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1452063005: Fixing base unittests impacted by Debug ASAN (Closed)

Created:
5 years, 1 month ago by Sean Klein
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fixing base unittests impacted by Debug ASAN Manually disables NewOverflow test with "defined(ADDRESS_SANITIZER)". Otherwise, fixes are pulled from Chromium. Pulls in the following from Chromium: 9ea8ee354b50ab621ea663636c5fc7a91c8e3226 Modifies: base/message_loop/message_pump_libevent.cc base/message_loop/message_pump_libevent.h 2b94f7bf55796a7112bd8dc5fafb0797e8bc9949 51cf93316e06b29111bd7f4c7ef8db8d3ad7b70a Modifies: base/message_loop/message_pump_libevent_unittest.cc 1bf93991ffe7bfe8adbf4f9fc92f2a1f287fc6ed Modifies: base/security_unittest.cc TEST='./mojo/tools/mojob.py build --asan --debug; ./mojo/tools/mojob.py test --asan --debug' R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d423877725e8606e5ebac142e5c4b5c8c2dc4810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -210 lines) Patch
M base/message_loop/message_pump_libevent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_libevent.cc View 2 chunks +22 lines, -10 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M base/security_unittest.cc View 4 chunks +2 lines, -194 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Sean Klein
PTAL -- Sorry for breaking the buildbots!
5 years, 1 month ago (2015-11-18 01:19:34 UTC) #3
jamesr
lgtm
5 years, 1 month ago (2015-11-18 18:57:25 UTC) #7
Sean Klein
5 years, 1 month ago (2015-11-19 00:17:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d423877725e8606e5ebac142e5c4b5c8c2dc4810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698